Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing for .net 7 previews 1 - 3 #8343

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

riarenas
Copy link
Member

#8319

To double check:

@riarenas
Copy link
Member Author

Let me know if there's something I'm missing! I'm not sure I'm up to date with all the latest changes to this space.

Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@mmitche
Copy link
Member

mmitche commented Jan 13, 2022

You all are wonderful. Thanks for handling this.

You also need the SDK channels too though. We use separate channels for runtime and sdk.

@riarenas
Copy link
Member Author

riarenas commented Jan 13, 2022

I knew that... derp. Do we want them the same way we had them for .net 6? ie .NET 7.0.1xx SDK Preview 1-3?

@mmitche
Copy link
Member

mmitche commented Jan 13, 2022

I knew that... derp. Do we want them the same way we had them for .net 6? ie .NET 7.0.1xx SDK Preview 1-3?

Yep same format

@riarenas
Copy link
Member Author

@adiaaida can you take another look? Tried to follow the existing patterns for the aka.ms channels for the current sdk channel, but not sure if those lists are right.

Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good. That's what I'd expect to see

@riarenas riarenas merged commit ecf92bb into dotnet:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants